Dan Kenigsberg has posted comments on this change.
Change subject: build: Disable tests during build
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/63966/3//COMMIT_MSG
Commit Message:
Line 5: CommitDate: 2016-09-15 01:45:00 +0300
Line 6:
Line 7: build: Disable tests during build
Line 8:
Line 9: Tests are needed for development, not for building a package. This
I don't subscribe to this postulate. spec files have a %check section for a reason: to
improve the chances that a sane code is being built.
Line 10: allows us to use latest and greatest development tools, which are not
Line 11: available in brew or koji.
Line 12:
Line 13: Since we install nose using pip, remove the build requires - we don't
--
To view, visit
https://gerrit.ovirt.org/63966
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e3589c365166f934f117b53c65cea4b90db3516
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes