Ondřej Svoboda has posted comments on this change.
Change subject: ipwrapper: Make Link.flags official as they are used for RUNNING and
PROMISC
......................................................................
Patch Set 1: Verified+1
(1 comment)
Static verification for now.
http://gerrit.ovirt.org/#/c/36621/1/lib/vdsm/ipwrapper.py
File lib/vdsm/ipwrapper.py:
Line 136: self.vlanprotocol = vlanprotocol
Line 137: if device is not None:
Line 138: self.device = device
Line 139: if flags is not None:
Line 140: self.flags = flags
Because this is a functional change (previously flags could be None) a verification seems
necessary.
Here goes: the only users of .flags (there are only a few occurences of .flags in git
grep) reside in the same class (Link) and use it unconditionally as an integer, e.g.:
@property
def oper_up(self):
return bool(self.flags & self.IFF_RUNNING)
Line 141: for key, value in kwargs.items():
Line 142: setattr(self, key, value)
Line 143:
Line 144: def __repr__(self):
--
To view, visit
http://gerrit.ovirt.org/36621
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc9e516e28d3413274af85dc15f72cabdb64074a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes