Dan Kenigsberg has posted comments on this change.
Change subject: contrib: Adding contrib/nfs-check.py
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(4 inline comments)
few more issues open (some scribed on previous code)
....................................................
File contrib/nfs-check.py
Line 46: self.nfsServer = None
naming: "self" is an "Nfs" object. so attribute does not have to start
with "nfs".
Line 84: if ret != 0 and localMachine == True:
this begs to be a separate function
Line 180: print output
printing numerical returncode is important for debugging.
Line 197: output = process.communicate()[1].strip()
this is output or errput?
--
To view, visit
http://gerrit.ovirt.org/916
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d3231077fb59e11be1d61a578a96a3988559ff3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>