Antoni Segura Puimedon has posted comments on this change.
Change subject: HostStats: stop storing list of host ifids and speeds
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/29470/2/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 100: return '0'
Line 101: return 'up' if flags & ethtool.IFF_RUNNING else
'down'
Line 102:
Line 103: def __init__(self, link):
Line 104: ifid = link.name
I'm being picky, I now. But let's have a future patch that changes this variable
name to devname of ifname. The id is well known to have a numeric value and it is a bit
confusing seeing it here used for something else.
Line 105: self.rx = self.readIfaceStat(ifid, 'rx_bytes')
Line 106: self.tx = self.readIfaceStat(ifid, 'tx_bytes')
Line 107: self.rxDropped = self.readIfaceStat(ifid, 'rx_dropped')
Line 108: self.txDropped = self.readIfaceStat(ifid, 'tx_dropped')
--
To view, visit
http://gerrit.ovirt.org/29470
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad0605c910564a8a7072484301c51b4b8a325751
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes