Federico Simoncelli has posted comments on this change.
Change subject: utils: add CommandStream class
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/33909/2/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 343: self.child.stdout.fileno(): stdoutcb,
Line 344: self.child.stderr.fileno(): stderrcb,
Line 345: }
Line 346:
Line 347: for fd in self.iocb.keys():
why not for fd in self.iocb ?
Done
Line 348: self.epoll.register(fd, select.EPOLLIN)
Line 349:
Line 350: def terminate(self):
Line 351: self.child.terminate()
Line 385: def wait(self, timeout=None):
Line 386: if timeout is None:
Line 387: epoll_remaining = -1
Line 388: else:
Line 389: endtime = os.times()[4] + timeout
+1
Done
Line 390:
Line 391: while self.returncode is None:
Line 392: if timeout is not None:
Line 393: epoll_remaining = endtime - os.times()[4]
--
To view, visit
http://gerrit.ovirt.org/33909
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie015368bb9c5992e5c73a149277c59fc4ffbd570
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes