Change in vdsm[master]: VolumeMetadata: Introduce class structure

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: VolumeMetadata: Introduce class structure
......................................................................


Patch Set 17: Code-Review-1

(1 comment)

Partial review

https://gerrit.ovirt.org/#/c/41844/17/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:

Line 113: 
Line 114: class BlockVolume(volume.Volume):
Line 115:     """ Actually represents a single volume (i.e. part of virtual
disk).
Line 116:     """
Line 117:     MetadataClass = BlockVolumeMetadata
metadataClass
Line 118: 
Line 119:     def __init__(self, repoPath, sdUUID, imgUUID, volUUID):
Line 120:         md = self.MetadataClass(repoPath, sdUUID, imgUUID, volUUID)
Line 121:         self.metaoff = None


-- 
To view, visit https://gerrit.ovirt.org/41844
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0552bea23b04b9e58e5d2cc7e016103d03194d1a
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com&gt;
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes