mooli tayer has posted comments on this change.
Change subject: Adding remove/disable verbs to vdsm-tool for admin usages
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/21772/9/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:
Line 31:
Line 32: P_SYSTEMCTL_CONF = SYSCONF_PATH + '/sysctl.d/vdsm'
Line 33: P_VDSM_LCONF = SYSCONF_PATH + '/libvirt/libvirtd.conf'
Line 34: P_VDSM_LDCONF = SYSCONF_PATH + '/sysconfig/libvirtd'
Line 35: P_VDSM_QCONF = SYSCONF_PATH + '/libvirt/qemu.conf'
you add it in this patch.. i say its redundant. i prefer to avoid
more cons
sorry I mean sysconfdir defined in autogen. so if we already have it would
it not be better to use it?
Line 36:
Line 37: def removeSectionFromFile(filename, beginField=None, endField=None):
Line 38: (
Line 39: BEFORE,
--
To view, visit
http://gerrit.ovirt.org/21772
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes