Bala.FA has posted comments on this change.
Change subject: Provide device details using python-blivet module
......................................................................
Patch Set 5: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/35028/5//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2014-11-11 16:34:46 +0530
Line 4: Commit: Timothy Asir <tjeyasin(a)redhat.com>
Line 5: CommitDate: 2014-11-18 21:37:18 +0530
Line 6:
Line 7: Provide device details using python-blivet module
Please add clear commit message like
gluster: add glusterStorageDevicesList verb
This patch adds new verb glusterStorageDevicesList which provides list of disks and
storage devices detail.
Output format is
<output dict format>
Line 8:
Line 9: This provides list of disks details of the host.
Line 10: The details are name, size, devPath, devUuid, fsName,
Line 11: mountPoint, fsUuid, formatedd or not.
http://gerrit.ovirt.org/#/c/35028/5/client/vdsClientGluster.py
File client/vdsClientGluster.py:
Line 430: pp.pprint(status)
Line 431: return status['status']['code'],
status['status']['message']
Line 432:
Line 433: def do_glusterStorageDeviceList(self, args):
Line 434: status = self.s.glusterStorageDeviceList()
Change glusterStorageDeviceList to glusterStorageDevicesList everywhere
Line 435: pp.pprint(status)
Line 436: return status['status']['code'],
status['status']['message']
Line 437:
Line 438:
http://gerrit.ovirt.org/#/c/35028/5/vdsm/gluster/apiwrapper.py
File vdsm/gluster/apiwrapper.py:
Line 77:
Line 78: def list(self):
Line 79: return self._gluster.hostsList()
Line 80:
Line 81: def deviceList(self, options=None):
Is it called like gluster.host.deviceList()? If so, please change function name to
storageDevicesList()
Line 82: return self._gluster.storageDeviceList()
Line 83:
Line 84:
Line 85: class GlusterService(GlusterApiBase):
http://gerrit.ovirt.org/#/c/35028/5/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 39: if device.format:
Line 40: info['fsType'] = device.format.type or ''
Line 41: if hasattr(device.format, 'mountpoint'):
Line 42: info['mountPoint'] = device.format.mountpoint
Line 43: if info['fsType'] or device.kids > 0 or \
Add new line before/after this if block as it deals with other properties.
Line 44: device.type in ['lvmvg', 'lvmthinpool']:
Line 45: info['formatted'] = True
Line 46: deviceList.append(info)
--
To view, visit
http://gerrit.ovirt.org/35028
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85f520c6f476731cb5982d8256cb701387be87cf
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nishanth Thomas <nishusemail(a)gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes