Nir Soffer has posted comments on this change.
Change subject: virt: Use Drive.diskType instead of networkDev and blockDev
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/40472/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1873: # update the type
Line 1874: diskDeviceXmlElement.setAttribute('type',
vmDrive.diskType)
Line 1875:
Line 1876: # update the path
Line 1877: attr = 'dev' if vmDrive.diskType == DISK_TYPE.BLOCK
else 'file'
not related to this (good) change, but regarding this topic branch.
This validation is indeed missing in the current code. I will add code failing
loudly if we get a network disk where we expect only file or block.
Line 1878: diskDeviceXmlElement.getElementsByTagName('source')[0].
\
Line 1879: setAttribute(attr, vmDrive.path)
Line 1880:
Line 1881: # update the format (the disk might have been collapsed)
--
To view, visit
https://gerrit.ovirt.org/40472
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id68bc74b3d788dc82fc61bf8c3de5a52164d0989
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes