Yaniv Bronhaim has posted comments on this change.
Change subject: isRunning didn't check local variable before reading saved data
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/supervdsm.py
Line 70: if not self._supervdsmProxy.isRunning():
Line 71: self._supervdsmProxy.launch()
Line 72:
Line 73: callMethod = lambda: \
Line 74: getattr(self._supervdsmProxy._svdsm, self._funcName)(*args,
You right, i thought that lambda functions are initialized once and not in each call.
but i checked and it's ok to create the lambda before _svdsm is initiated, and when we
call to callMethod() it'll get the current _svdsm.
Line 75: **kwargs)
Line 76: try:
Line 77: return callMethod()
Line 78: # handling internal exception that we raise to identify supervdsm
--
To view, visit
http://gerrit.ovirt.org/10491
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9dec0c6955dadcd959cc1c8df4e9745322fb0ce3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server