Dan Kenigsberg has posted comments on this change.
Change subject: net test: Replacing MonkeyPatch with mock.patch for netinfo_test
......................................................................
Patch Set 3:
(1 comment)
partial review
https://gerrit.ovirt.org/#/c/61269/3/tests/network/netinfo_test.py
File tests/network/netinfo_test.py:
PS3, Line 134: for addr in nl_addr.iter_addrs():
: # Link-local IPv6 addresses are generated from the MAC
address,
: # which is shared between a nic and its bridge. Since We
don't
: # support having the same IP address on two different NICs,
and
: # link-local IPv6 addresses aren't interesting for
'getDeviceByIP'
: # then ignore them in the test
: if addr['scope'] != 'link':
: self.assertEqual(
: addr['label'],
:
addresses.getDeviceByIP(addr['address'].split('/')[0]))
this seems unrelated to mock introduction. I think that this test should not depend on the
host having interfaces.
--
To view, visit
https://gerrit.ovirt.org/61269
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4e14162bb2773c50e551f4409c4c37cffe9f2a3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes