Douglas Schilling Landgraf has posted comments on this change.
Change subject: tests: Test schema validity
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Adding -1 since I do believe we need to add the test into Makefile.
....................................................
File tests/schemaTests.py
Line 41: class SchemaTest(TestCaseBase):
Line 42: def setUp(self):
Line 43: self.schema = findSchema()
Line 44:
Line 45: def testSchemaParse(self):
Adam, I do believe it's missing you add schemaTests.py to tests/Makefile.am.
Line 46: with open(self.schema) as f:
--
To view, visit
http://gerrit.ovirt.org/10050
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7680aaf8eb41546e3a8d38e405c7f9ed8bdd192
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server