Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
......................................................................
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/59834/14/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
PS14, Line 816: FileIO
OK, which kind of unexpected behaviour? I'm just worried this
could hide ot
Data loss to be precise. I also forgot to mention that it is prevented
by Python. When trying to mix the read methods I get the exception:
ValueError: Mixing iteration and read methods would lose data
--
To view, visit
https://gerrit.ovirt.org/59834
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes