Dan Kenigsberg has posted comments on this change.
Change subject: BZ#842948: deployUtil - safely remove bridge
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm_reg/deployUtil.py.in
Line 908: if isOvirt():
we are already under fIsOvirt==True (see line 898 above) so no need for this repetition.
Line 909:
ovirtfunctions.ovirt_safe_delete_config(''.join([IFACE_CONFIG, mgtBridge]))
I do not see any benefit of this join over a simple '+'.
--
To view, visit
http://gerrit.ovirt.org/6634
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e9b00ee4a38ebe7d5011e36bd9d3f7362cf26cd
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>