Francesco Romani has posted comments on this change.
Change subject: virt: Correct VM state before vm.cont() in _recover()
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
now that this works, let's check better alternatives. -1 for visibility.
https://gerrit.ovirt.org/#/c/47527/1/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 212: except Exception:
Line 213: self.log.exception("Failed to destroy remote VM")
Line 214: # if the guest was stopped before migration, we need to cont it
Line 215: if self.hibernating:
Line 216: self._vm.lastStatus = vmstatus.PAUSED
IMO better to reset this status when/if the hook raises, with a comment that reminds us it
is pretty much a workaround.
Line 217: self._vm.cont()
Line 218: # either way, migration has finished
Line 219: self._vm.lastStatus = vmstatus.UP
Line 220: self._vm.send_status_event()
--
To view, visit
https://gerrit.ovirt.org/47527
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b1c7b4eecacf87ece48dc563fd2da294af0510b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes