Federico Simoncelli has posted comments on this change.
Change subject: Live Merge: add reconcileVolumeChain verb
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Minor comment.
http://gerrit.ovirt.org/#/c/31788/6/vdsm/storage/image.py
File vdsm/storage/image.py:
Line 1138: elif len(subChain) > 0:
Line 1139: break
Line 1140: if len(subChain) == 0:
Line 1141: return
Line 1142: self.log.debug("unlinking subchain: %s" % subChain)
moving the logging here is correct but it wasn't part of this patch.
Line 1143:
Line 1144: sdDom = sdCache.produce(sdUUID=sdUUID)
Line 1145: dstParent = sdDom.produceVolume(imgUUID, subChain[0]).getParent()
Line 1146: subChainTailVol = sdDom.produceVolume(imgUUID, subChain[-1])
--
To view, visit
http://gerrit.ovirt.org/31788
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8927a42d2bc9adcf7c6b26babb327a00e91e49e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes