From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: janitorial: drop once-used P_VDSM_KEYS
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/77468/2/lib/vdsm/tool/configurators/passwd.py
File lib/vdsm/tool/configurators/passwd.py:
Line 37: _SASLPASSWD2 = cmdutils.CommandPath("saslpasswd2",
Line 38: "/usr/sbin/saslpasswd2",
Line 39: )
Line 40: SASL_USERNAME = "vdsm@ovirt"
Line 41: LIBVIRT_PASSWORD_PATH = os.path.join(constants.PKI_DIR,
'libvirt_password')
Why not:
mmmm, this would leak the "keys" element out
of constants.py
Line 42:
Line 43:
Line 44: def isconfigured():
Line 45: script = (str(_SASLDBLISTUSERS2), '-f', _LIBVIRT_SASLDB)
--
To view, visit
https://gerrit.ovirt.org/77468
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I588a94534d2813bc9ffdd1688364cea0e7516170
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes