Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: vm payload: add file injection to vm
......................................................................
Patch Set 12: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/clientIF.py
Line 207: for key, files in
drive['specParams']['vmPayload']:
I think you need to use iteritems() on a dict to iterate it.
....................................................
File vdsm/libvirtvm.py
Line 2029: for drive in self._devicesr[vm.DISK_DEVICES]:
s/_devicesr/_devices/
Line 2032: supervdsm.getProxy().mkIsoFs(drive['path'])
I'm not sure what you're trying to do here. Did you mean removeFs?
--
To view, visit
http://gerrit.ovirt.org/2321
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>