Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: report DHCP on devices only when configured (like for networks)
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/45504/3/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 2067: self.assertEqual(reported_device['dhcpv4'], requested_dhcpv4)
This check fails in all DHCPv4 instances of the test (even in the first call of
_assert_applied at line 2095) with:
False != True (dhcpv4 is not reported on the device even though requested)
I'll look for the cause.
--
To view, visit
https://gerrit.ovirt.org/45504
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b17b0c66e3a0fc8c5ada62d166d9a2b92513033
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes