Dan Kenigsberg has posted comments on this change.
Change subject: new verb: migration cancel
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/vm.py
Line 235: 'message': 'Migration canceled'}}
exception is not re-raised here, _recover is not called, and nothing resets Vm state.
this block should probably moved out to line 240 below, or better be moved into
_startUnderlyingMigration() with a reraise.
--
To view, visit
http://gerrit.ovirt.org/480
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f503c444c4ca1469c18480d6ca29fba8f011d4c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>