Change in vdsm[master]: lvm: Fail loudly if called with unexpected input

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: lvm: Fail loudly if called with unexpected input
......................................................................

Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/37329/3/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:

Line 731: 
Line 732:     if force is True:
Line 733:         options = ("-y", "-ff")
Line 734:         _initpvs_removeHolders()
Line 735:     else:
> how about adding it after an

It does not express the intent of the code.

The code is about:

1. Validate input
2. Handle True or False

And not about:

1. Handle one of the values True, False, Other
Line 736:         options = tuple()
Line 737: 
Line 738:     rc, out, err = _createpv(devices, metadataSize, options)
Line 739:     _lvminfo._invalidatepvs(devices)