Eduardo has posted comments on this change.
Change subject: image: copying a template is always allowed
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/hsm.py
Line 1317: "because the template %s is missing on the
"
Line 1318: "destination", imgUUID, dstDom.sdUUID,
tName)
Line 1319: raise se.ImageDoesNotExistInSD(imgUUID, dstDom.sdUUID)
Line 1320: elif (safeToMove and imgUUID == tImgs[0]
Line 1321: and not srcDom.isBackup()):
1) This method have at maximum two IO calls. glob or vgs according to file or block based
storage.
2) When copying a template the hsm.copyImage() should be called instead of calling
hsm.moveImage(op="copy"). Therefore this validation is not called.
This function was written to preserve all the old (broken) semantics of VDSM.
Copying a template to another data SD was verified (succeed) with the actual code, since
hsm.copy image is called.
3) Allowing broken images in a regular (data) SD is a very deep change that breaks the
fact that (actually) PDIV images are totally contained in a data SD.
In spite that this change is desirable, can't and shouldn't be done only here.
Line 1322: raise se.MoveTemplateImageError(imgUUID)
Line 1323:
Line 1324: break
Line 1325:
--
To view, visit
http://gerrit.ovirt.org/8408
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e07d569eec02ac4dcd386a7c576342f640ec242
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>