Ido Barkan has posted comments on this change.
Change subject: openstacknet: Fix migration when using security groups
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/34406/1/vdsm_hooks/openstacknet/before_device...
File vdsm_hooks/openstacknet/before_device_migrate_destination.py:
Line 54: setUpSecurityGroupVnic(mac, portId)
Line 55:
Line 56:
Line 57: def test():
Line 58: """Should create:
nothing should get really created, just lines printed. since the arguments are pre-set,
you can show the tester what output to expect.
Line 59: - qbrtest_port_i linux bridge
Line 60: - qvbtest_port_i veth attached to the bridge above
Line 61: - qvbtest_port_i matching veth attached to the br-int with portId
Line 62: 'test_port_id' and mac '00:1a:4a:16:01:51'
--
To view, visit
http://gerrit.ovirt.org/34406
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd8a789c4565f32b32965af3966a4edd361949ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes