Change in vdsm[master]: tool: change configurators from classes to modules.

mooli tayer has posted comments on this change.

Change subject: tool: change configurators from classes to modules.
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/34047/3/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 60:     initialization.
Line 61: 
Line 62:     Note: after configure isconfigured should return NOT_SURE or CONFIGURED.
Line 63: 
Line 64: removeConf:   [optional function]
>  Missing \n 
done
Line 65:     Cleanup vdsm's configuration.
Line 66: """
Line 67: 
Line 68: 


Line 236: 
Line 237:     while queue:
Line 238:         next_ = queue.popleft()
Line 239:         try:
Line 240:             requiredNames = getattr(_CONFIGURATORS[next_],
>  do alonbl style 
yay, done
Line 241:                                     'requires',
Line 242:                                     frozenset())
Line 243:         except KeyError:
Line 244:             available = ', '.join(sorted(_CONFIGURATORS))


-- 
To view, visit http://gerrit.ovirt.org/34047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5d588cfbbcfe0d5f4a90d624d24f21ef4cc580
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dima Kuznetsov <dkuznets(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes