Dan Kenigsberg has posted comments on this change.
Change subject: new verb: migration cancel
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 442: def stop(self):
apparently, this is not good enough, if migration thread is still in migrationCreate (line
408 above) or anywhere before _dom.migrateToURI2 takes effect.
I do not see a way to avoid synchronizing between MigrationSourceThread and the new
migrationCancel verb.
(thanks Peter for helping to find this issue)
--
To view, visit
http://gerrit.ovirt.org/480
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f503c444c4ca1469c18480d6ca29fba8f011d4c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>