Francesco Romani has posted comments on this change.
Change subject: Live Merge: Restore watermark tracking
......................................................................
Patch Set 2:
(4 comments)
-1 for visibility
https://gerrit.ovirt.org/#/c/60889/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS2, Line 920: mergeCandidates
how do you use this?
PS2, Line 936: if not self.conf['_blockJobs'].values():
: return {}
why not just:
if not self.conf['_blockJobs']:
return {}
plus, more important: let's check carefully about the locking here.
PS2, Line 941: stats_cache
please note that this is updated each 15s - and it is modifiable by the users. Is this
good enough for live merge?
PS2, Line 981: getVolumeInfo
how costly is this?
--
To view, visit
https://gerrit.ovirt.org/60889
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52199bb38a2d3f439d33b9e78743c3e611349672
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes