Dan Kenigsberg has posted comments on this change.
Change subject: BZ#733669 Return specific error for invalid host
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
Commit Message
Line 7: BZ#733669 Return specific error for invalid host
Sorry for only noticing this now, but the commit message is not good enough for a piece of
code we would like to revert when we start using virDomainMigrateToURI2. (well, almost
revert. I'd like to keep the bubbling of the error code)
Please describe the problem at had, and mention that this restriction is to be dropped
--
To view, visit
http://gerrit.usersys.redhat.com/924
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf0ae2d62772b01d05d9d5e62d2433c1758d69b1
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>