Dan Kenigsberg has posted comments on this change.
Change subject: Introduce API getBalloonInfo and setBalloonTarget
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/vm.py
Line 933: self.conf['balloon'] = self.getBalloonInfo()
but we already poll cpu usage (git grep dom.info). we could pretty easily poll and cache
balloon size.
We had bad experience with verbs that may block Engine/Vdsm traffic due to a hung qemu
process. Let us try to avoid that, as well a a need for a new and costy per-vm polling
verb. If you have 200 Vm and the client polls each and every one's balloon separately,
for all hosts, your client would become pretty busy pretty quickly.
--
To view, visit
http://gerrit.ovirt.org/3669
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I36b1211dbce28bb5bb5926f2db7e2e42a698efc9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>