Change in vdsm[master]: Hotplug/Hotunplug disks

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: Hotplug/Hotunplug disks
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

not reviewed yet, sorry

....................................................
File vdsm/clientIF.py
Line 618:         except KeyError:
I prefer to take the hotplugDisk(params) call outside try--except: if for some reason
KeyError is raised in hotplug, we won't be logging it.

--
To view, visit http://gerrit.ovirt.org/409
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5feefdba390c4b885aaa5e61f40410419acb3b3c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com&gt;