Antoni Segura Puimedon has posted comments on this change.
Change subject: syncproc: Add blocking mode.
......................................................................
Patch Set 9:
(1 comment)
Some very minor nit/proposal
....................................................
File lib/vdsm/utils.py
Line 345: else:
Line 346: return res
Line 347:
Line 348: def read(self, length):
Line 349: if not self._parent.blocking:
I'd find more readable if it were first the positive branch of the if and then the
negative one:
if not self._parent.blocking:
res = None
while res is None:
res = self._readNonBlock(length)
else:
res = self._readNonBlock(length)
return res
Line 350: return self._readNonBlock(length)
Line 351: else:
Line 352: res = None
Line 353: while res is None:
--
To view, visit
http://gerrit.ovirt.org/21897
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id406249bfd63f59f273d27614a38a43595f1d7e1
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes