Mark Wu has posted comments on this change.
Change subject: Fix another mac address comparison issue caused by letter case. ......................................................................
Patch Set 1:
I got the following exception before the fix. It happened because the network device in vm's conf was not updated with alias. But I am not sure why it's only happened after I upgraded vdsm.
File "/usr/share/vdsm/vm.py", line 534, in _startUnderlyingVm self._run() File "/usr/share/vdsm/libvirtvm.py", line 1280, in _run self._domDependentInit() File "/usr/share/vdsm/libvirtvm.py", line 1174, in _domDependentInit self._getUnderlyingVmDevicesInfo() File "/usr/share/vdsm/libvirtvm.py", line 1161, in _getUnderlyingVmDevicesInfo self._getUnderlyingUnknownDeviceInfo() File "/usr/share/vdsm/libvirtvm.py", line 1815, in _getUnderlyingUnknownDeviceInfo if not isKnownDevice(alias): File "/usr/share/vdsm/libvirtvm.py", line 1801, in isKnownDevice if dev['alias'] == alias: KeyError: 'alias'
-- To view, visit http://gerrit.ovirt.org/1696 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I5f45e2698d929e59f5d5d78b6ca12cb6b8eba445 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com