Yaniv Bronhaim has posted comments on this change.
Change subject: Adding toolTests.py to python3 check modules
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/48052/7/lib/vdsm/tool/configfile.py
File lib/vdsm/tool/configfile.py:
Line 262:
Line 263: def read(self, path):
Line 264: with open(path, 'r') as f:
Line 265: return self.wrapped.readfp(
Line 266: io.StringIO(u'[root]\n' + f.read())
Are you sure it works for both 2 and 3?
the decode is indeed
not required here both in python 3 and 2
--
To view, visit
https://gerrit.ovirt.org/48052
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52f11a1a10cae46773d05d0c09da80ad8eb3b772
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes