Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
......................................................................
Patch Set 13:
(4 comments)
Mostly splitting parts into separate commits. Added code for removing old log files
https://gerrit.ovirt.org/#/c/59834/13/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 648: ret.append(vol['path'])
Line 649: return ret
Line 650:
Line 651:
Line 652: class PipelineProc(object):
good project standards would require this to be in a separate change,
with
Separated into
https://gerrit.ovirt.org/#/c/62094
Line 653:
Line 654: def __init__(self, proc1, proc2):
Line 655: self._proc = (proc1, proc2)
Line 656: self._stdout = proc2.stdout
Line 802: self._id, self._proc.pid)
Line 803:
Line 804: def _watch_process_output(self):
Line 805: out = io.BufferedReader(io.FileIO(self._proc.stdout.fileno(),
Line 806: mode='r', closefd=False), BUFFSIZE)
I didn't see this before. Seems OK, but could you please
elaborate why we n
This is needed to avoid rewriting OutputParser. Aparently using
both iteration and read() on a simple File object can lead to undefined behaviour.
Line 807: parser = OutputParser()
Line 808: for event in parser.parse(out):
Line 809: if isinstance(event, ImportProgress):
Line 810: self._status = STATUS.COPYING_DISK
Line 1217: net['type'] = 'interface'
Line 1218: vm['networks'].append(net)
Line 1219:
Line 1220:
Line 1221: def _simple_exec_cmd(command, env=None, nice=None, ioclass=None,
good project standards would require this to be in a separate change,
with
Separated into
https://gerrit.ovirt.org/#/c/62092
Line 1222: stdin=subprocess.PIPE, stdout=subprocess.PIPE,
Line 1223: stderr=subprocess.PIPE):
Line 1224:
Line 1225: command = cmdutils.wrap_command(command, with_ioclass=ioclass,
https://gerrit.ovirt.org/#/c/59834/13/vdsm.spec.in
File vdsm.spec.in:
Line 81: BuildRequires: openssl
Line 82: BuildRequires: policycoreutils-python
Line 83: BuildRequires: psmisc
Line 84: BuildRequires: PyYAML
Line 85: BuildRequires: python-cpopen >= 1.4-1
good project standards would require this to be in a separate trivial
chang
Separated into
https://gerrit.ovirt.org/#/c/62093
Line 86: BuildRequires: python-inotify
Line 87: BuildRequires: python-ioprocess >= 0.16.1-1
Line 88: BuildRequires: python-pthreading
Line 89: BuildRequires: qemu-img
--
To view, visit
https://gerrit.ovirt.org/59834
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes