Dan Kenigsberg has submitted this change and it was merged.
Change subject: API: streamline and make setLogLevel correct ......................................................................
API: streamline and make setLogLevel correct
According to the schema, setLogLevel should accept a log level string ('DEBUG', 'INFO',...). But the code actually blindly casted the given value to int(), and this suggests the code actually expected an integer value.
To make things a bit user friendlier and comformant to schema, change the argument to actually be a log level in string format.
Along the way, this patch streamlines the implementation of setLogLevel and makes it simpler.
Change-Id: Iaddbb12d13bdbaa7a02255ab209da11e42d2ea97 Backports-To: 4.0 Backports-To: 3.6 Signed-off-by: Francesco Romani fromani@redhat.com Reviewed-on: https://gerrit.ovirt.org/38425 Reviewed-by: Piotr Kliczewski piotr.kliczewski@gmail.com Reviewed-by: Dan Kenigsberg danken@redhat.com Continuous-Integration: Dan Kenigsberg danken@redhat.com --- M lib/vdsm/logUtils.py 1 file changed, 14 insertions(+), 1 deletion(-)
Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved; Passed CI tests Francesco Romani: Verified
Objections: Jenkins CI: Failed CI tests