Bala.FA has posted comments on this change.
Change subject: gluster: geo-replication configuration related verbs.
......................................................................
Patch Set 8: Code-Review-1
(5 comments)
Replace 'key' to 'option' everywhere in this patch
http://gerrit.ovirt.org/#/c/30162/8/vdsm/gluster/api.py
File vdsm/gluster/api.py:
Line 399: key, value, options=None):
Line 400: self.svdsmProxy.glusterVolumeGeoRepConfig(volumeName,
Line 401: remoteHost,
Line 402: remoteVolumeName,
Line 403: key,
Please change key to option here too
Line 404: value)
Line 405:
Line 406: @exportAsVerb
Line 407: def volumeGeoRepConfigReset(self, volumeName, remoteHost,
Line 410: self.svdsmProxy.glusterVolumeGeoRepConfig(
Line 411: volumeName,
Line 412: remoteHost,
Line 413: remoteVolumeName,
Line 414: key)
same here
Line 415:
Line 416:
Line 417: def getGlusterMethods(gluster):
Line 418: l = []
http://gerrit.ovirt.org/#/c/30162/8/vdsm/gluster/apiwrapper.py
File vdsm/gluster/apiwrapper.py:
Line 228:
Line 229: def geoRepConfigSet(self, volumeName, remoteHost, remoteVolumeName,
Line 230: key, value):
Line 231: return self._gluster.volumeGeoRepConfigSet(volumeName, remoteHost,
Line 232: remoteVolumeName, key,
change key to option
Line 233: value)
Line 234:
Line 235: def geoRepConfigReset(self, volumeName, remoteHost,
Line 236: remoteVolumeName, key):
Line 236: remoteVolumeName, key):
Line 237: return self._gluster.volumeGeoRepConfigReset(volumeName,
Line 238: remoteHost,
Line 239: remoteVolumeName,
Line 240: key)
same here
http://gerrit.ovirt.org/#/c/30162/8/vdsm/gluster/cli.py
File vdsm/gluster/cli.py:
Line 1216:
Line 1217:
Line 1218: @makePublic
Line 1219: def volumeGeoRepConfig(volumeName, remoteHost,
Line 1220: remoteVolumeName, key=None,
Change key to option
Line 1221: value=None):
Line 1222: command = _getGlusterVolGeoRepCmd() + [volumeName, "%s::%s" % (
Line 1223: remoteHost, remoteVolumeName), "config"]
Line 1224: if key and value:
--
To view, visit
http://gerrit.ovirt.org/30162
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifee571dbf3c56633e415d32f8d518cb64aaf1add
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes