Francesco Romani has posted comments on this change.
Change subject: static: move man under static
......................................................................
Patch Set 5: Code-Review+1
(3 comments)
https://gerrit.ovirt.org/#/c/62549/5/static/Makefile.am
File static/Makefile.am:
PS5, Line 24: usr
same comment as parent patch about hardcoded paths.
Not really sure this is relevant, but still this rings a bell
PS5, Line 33: etc
hardcoding /etc is kinda fine, a lot of thing can broke otherwise, but stuff under /usr
has a greater degree of flexibility, thus seems worth a bit more discussion.
PS5, Line 93: ./usr/lib/systemd
(yes, I noticed too late)
this seems kinda ok, because I think systemd is not that flexible. But still, under the
same caregory of /usr paths (obviously)
--
To view, visit
https://gerrit.ovirt.org/62549
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91fa36b38904d85fc60734ce966b8d993911b490
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes