Yeela Kaplan has posted comments on this change.
Change subject: misc: remove cp parameter
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/45613/1/vdsm/storage/misc.py
File vdsm/storage/misc.py:
Line 488:
EXT_CP should be dropped from constants, too.
EXT_CP is still
used in multipath configurator
Line 483: utils.unpersist(newName)
Line 484: except:
Line 485: pass
Line 486:
Line 487: os.rename(oldName, newName)
the original except:pass was horrible, but you should not change the
logic
Done
Line 488:
Line 489: if utils.isOvirtNode() and persist:
Line 490: try:
Line 491: utils.persist(newName)
--
To view, visit
https://gerrit.ovirt.org/45613
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0906bfd7dfa128c323aa399810bbd75883618434
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes