Change in vdsm[master]: vdsm: verifyingTransport testing

[Nir Soffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm: verifyingTransport testing
......................................................................


Patch Set 9:

(1 comment)

Nice - but there is duplicate test.

http://gerrit.ovirt.org/#/c/28858/9/tests/sslTests.py
File tests/sslTests.py:

Line 122:         with verifyingclient(KEY_FILE, OTHER_CRT_FILE) as client:
Line 123:             with self.assertRaises(ssl.SSLError):
Line 124:                 client.add(2, 3)
Line 125: 
Line 126:     def test_key_do_not_match_with_cert(self):
This is the same as test_cert_do_not_match_with_key - did you mean to use different
combination here?
Line 127:         with verifyingclient(KEY_FILE, OTHER_CRT_FILE) as client:
Line 128:             with self.assertRaises(ssl.SSLError):
Line 129:                 client.add(2, 3)
Line 130: 


-- 
To view, visit http://gerrit.ovirt.org/28858
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a706d4d90fdf446b06530288d947d96934e45f2
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes