Eduardo has posted comments on this change.
Change subject: Relink template hard links to meta and lease files
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 1245: return vg.name
Line 1246:
Line 1247: raise se.StorageDomainDoesNotExist()
Line 1248:
Line 1249: def templateRelink(self, imgUUID, volUUID):
templateRelink() is not an StorageDomain method. Is a special method of
FileStorageDomains. Then it should not be inherited be all the SDs.
Really, it should not be called for blockStorageDomains and will not, when we will
finished with the split of image functions. Meanwhile this is BC.
Line 1250: """
Line 1251: Relink all hardlinks of the template 'volUUID' in all VMs based
on it.
Line 1252: No need to relink template for block domains.
Line 1253: """
--
To view, visit
http://gerrit.ovirt.org/12837
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idce0f3f1812fdf45efeeeffcccb7dc22b3b0d0f0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server