Ido Barkan has posted comments on this change.
Change subject: net: run dhclient in its own process group.
......................................................................
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/43853/6/vdsm/network/configurators/dhclient.py
File vdsm/network/configurators/dhclient.py:
Line 57: kill_dhclient(self.iface)
Line 58: cmd = [self.DHCLIENT.cmd, '-1', '-pf', self.pidFile,
'-lf',
Line 59: self.leaseFile, self.iface]
Line 60: if not EL6:
Line 61: cmd = cmdutils.systemd_run(cmd, scope=True, slice=self._cgroup)
Here you don't check for None self._cgroup. Lets be consistent
with ifup. E
this code should check if self._cgroup is not None. same as in
ifcfg.py
Line 62:
Line 63: rc, out, err = execCmd(cmd)
Line 64: return rc, out, err
Line 65:
https://gerrit.ovirt.org/#/c/43853/6/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:
Line 791: "Bring up an interface"
Line 792: def _ifup(netIf):
Line 793: cmd = [constants.EXT_IFUP, netIf]
Line 794:
Line 795: if not EL6 and cgroup is not None:
cgroup is a new argument, and I don't see code in this patch
calling ifup w
this is indeed the same as master. if future backports will pass
None, it is supported.
Line 796: cmd = cmdutils.systemd_run(cmd, scope=True, slice=cgroup)
Line 797:
Line 798: rc, out, err = utils.execCmd(cmd, raw=False)
Line 799:
--
To view, visit
https://gerrit.ovirt.org/43853
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82848a36b52cd8e9dec188d865ef86edc4bb7488
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes