Alon Bar-Lev has posted comments on this change.
Change subject: Adding remove/disable verbs to vdsm-tool for admin usages
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/21772/5/lib/vdsm/tool/passwd.py
File lib/vdsm/tool/passwd.py:
Line 43: script, stdin=f, stdout=subprocess.PIPE,
Line 44: stderr=subprocess.PIPE, close_fds=True)
Line 45: output, err = p.communicate()
Line 46: if p.returncode != 0:
Line 47: raise RuntimeError("Set password failed: %s" % (err, ))
why is this related to this patch?
Line 48:
Line 49:
Line 50: @expose("remove-saslpasswd")
Line 51: def remove_saslpasswd():
Line 55: rc, out, err = utils.execCmd(
Line 56: (constants.EXT_SASLPASSWD2, '-p', '-a',
'libvirt', '-d', constants.SASL_USERNAME,),
Line 57: )
Line 58: if rc != 0:
Line 59: raise RuntimeError("Remove password failed: %s" % (err, ))
just thought I revisit this... why do you need tuple for err?
--
To view, visit
http://gerrit.ovirt.org/21772
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes