Change in vdsm[master]: image: copying a template is always allowed

Shu Ming has posted comments on this change.

Change subject: image: copying a template is always allowed
......................................................................


Patch Set 1: (1 inline comment)

The comments are quite confusing to me.

....................................................
File vdsm/storage/hsm.py
Line 1296:         allowed only if the template already exists on the target domain.
Line 1297:         When the option safeToMove (default: False) is active (True) an
Line 1298:         extra check makes sure that if the image is a template (on a data
Line 1299:         domain) then there are no other images based on it and therefore it
Line 1300:         is safe to remove it.
I think it would be better to explain the two cases more clearly. Like, case I:  coping or
moving an image based on a template
case II: moving an template, an extra check make sure that ...
Line 1301:         """
Line 1302:         srcAllVols = srcDom.getAllVolumes()
Line 1303:         dstAllVols = dstDom.getAllVolumes()
Line 1304: 


--
To view, visit http://gerrit.ovirt.org/8408
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e07d569eec02ac4dcd386a7c576342f640ec242
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com&gt;
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com&gt;