Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit
......................................................................
Patch Set 4:
(3 comments)
https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line 380:
Line 381: qemuimg.create(base, size=size, format=qemuimg.FORMAT.RAW)
Line 382: qemu_pattern_write(base, qemuimg.FORMAT.RAW, '0', 0xf0)
Line 383:
Line 384: qemuimg.create(internal, size=size, format=qemuimg.FORMAT.QCOW2,
size is not needed when creating image with backing chain.
Line 385: backing=base)
Line 386: qemu_pattern_write(internal, qemuimg.FORMAT.QCOW2, '512',
0xf1)
Line 387:
Line 388: qemuimg.create(top, format=qemuimg.FORMAT.QCOW2, backing=internal)
Line 385: backing=base)
Line 386: qemu_pattern_write(internal, qemuimg.FORMAT.QCOW2, '512',
0xf1)
Line 387:
Line 388: qemuimg.create(top, format=qemuimg.FORMAT.QCOW2, backing=internal)
Line 389: qemu_pattern_write(top, qemuimg.FORMAT.QCOW2, '800', 0xf2)
Use same offsets and patterns as in the previous test :
- base: 0-1k, 0xf0
- internal: 1k-2k, 0xf1
- top: 2k-3k, 0xf2
Line 390:
Line 391: op = qemuimg.commit(top, base=base)
Line 392: op.wait_for_completion()
Line 393:
Line 396:
Line 397: # base now should include original data and top's data
Line 398: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '0', 0xf2)
Line 399: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '512', 0xf1)
Line 400: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '800', 0xf2)
Use kwargs and same offsets.
--
To view, visit
https://gerrit.ovirt.org/64222
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes