Change in vdsm[master]: do not delete networks from parameters

[Dan Kenigsberg]

Dan Kenigsberg has posted comments on this change.

Change subject: do not delete networks from parameters
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/35690/1/vdsm/network/api.py
File vdsm/network/api.py:

Line 669:     logger.debug("Applying...")
Line 670:     with ConfiguratorClass(options.get('_inRollback', False)) as
configurator:
Line 671:         networks_to_add = dict(
Line 672:             (net, attributes)
Line 673:             for net, attributes in networks.iteritems()
attributes->attrs (for consistency)

But if we do not modify the networks dict, why define this temp variable, and why have it
so far from its usage?
Line 674:             if 'remove' not in attributes)
Line 675:         # Remove edited networks and networks with 'remove' attribute
Line 676:         for network, attrs in networks.items():
Line 677:             if network in _netinfo.networks:


-- 
To view, visit http://gerrit.ovirt.org/35690
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I546c7f196f4b6bdace528a0cbbe6cfe5a212bfe1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes