Liron Aravot has posted comments on this change.
Change subject: hooks: Add disk hot plug/unplug hooks
......................................................................
Patch Set 8: (1 inline comment)
....................................................
File vdsm/libvirtvm.py
Line 1739: driveXml = drive.getXML().toprettyxml(encoding='utf-8')
Line 1740: self.log.debug("Hotplug disk xml: %s" % (driveXml))
Line 1741:
Line 1742: try:
Line 1743: hooks.before_disk_hotplug(driveXml, self.conf)
shouldn't it be done here also outside of the try/except?
Line 1744: self._dom.attachDevice(driveXml)
Line 1745: hooks.after_disk_hotplug(driveXml, self.conf)
Line 1746: except libvirt.libvirtError as e:
Line 1747: self.log.error("Hotplug failed", exc_info=True)
--
To view, visit
http://gerrit.ovirt.org/12479
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10b689964fad3a1118974f7ba7b91e795cbffd1f
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server