Change in vdsm[master]: scsi: Scan only the required domain type

Adam Litke has posted comments on this change.

Change subject: scsi: Scan only the required domain type
......................................................................


Patch Set 1:

This one worries me.  The sdCache has a state machine that assumes that we are not doing
partial refreshes.  I'm concerned about the potential for race conditions where one
thread refreshes some storage while another thread is blocked on refresh of the other type
of storage.  Although I cannot see anything clearly wrong in this patch, I'm still not
convinced it's correct.

-- 
To view, visit https://gerrit.ovirt.org/45824
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic32cd683020e94df016dd77b19ae3eb7317c5554
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com&gt;
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com&gt;
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: No