Change in vdsm[master]: vdsm.spec: change 'make check' to 'make unittest'
Edward Haas has posted comments on this change.
Change subject: vdsm.spec: change 'make check' to 'make unittest'
......................................................................
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/59417/2//COMMIT_MSG
Commit Message:
Line 10: using tox.
Line 11: not all machines support tox and there are some issues
Line 12: running tox without network.
Line 13: separating style validation from tests enables creating an rpm
Line 14: without style.
make check can be equal to make unittests, as it runs recursively
check-loc
How about this:
check: check-style check-tests ...
check-style: pep8 pyflakes
check-tests: check-unit check-integration
I am also in favor of dropping the recursive built-in check and instead explicitly call
the relevant sub-directory.
Having overlapping targets is also not recommend, I would prefer to see each with its own
target and an aggregated target. The disadvantage is that the test-run is separated by
types (unless we can build an args variable per target?).
If we can avoid flags, it will be cleaner IMO.
Line 15:
Line 16: Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571
https://gerrit.ovirt.org/#/c/59417/3/Makefile.am
File Makefile.am:
PS3, Line 127: unittest
tests includes all kind of tests, not only unit tests.
How about naming the target as 'tests'?
--
To view, visit https://gerrit.ovirt.org/59417
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes