Nir Soffer has posted comments on this change.
Change subject: [WIP] core: Expose API for qemuimg commit
......................................................................
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/64222/4/tests/qemuimg_test.py
File tests/qemuimg_test.py:
Line 338: @MonkeyPatch(qemuimg, 'config', CONFIG)
Line 339: def test_write_and_verify(self):
Line 340: with namedTemporaryDir() as tmpdir:
Line 341: base = os.path.join(tmpdir, 'base.img')
Line 342: size = 1048576
We don't need this variable, just inline the value bellow.
Line 343:
Line 344: qemuimg.create(base, size=size, format=qemuimg.FORMAT.RAW)
Line 345: qemu_pattern_write(base, qemuimg.FORMAT.RAW, '0')
Line 346: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '0', 0xf1)
Line 340: with namedTemporaryDir() as tmpdir:
Line 341: base = os.path.join(tmpdir, 'base.img')
Line 342: size = 1048576
Line 343:
Line 344: qemuimg.create(base, size=size, format=qemuimg.FORMAT.RAW)
size=10485576 is fine.
Line 345: qemu_pattern_write(base, qemuimg.FORMAT.RAW, '0')
Line 346: qemu_pattern_verify(base, qemuimg.FORMAT.RAW, '0', 0xf1)
Line 347:
Line 348:
--
To view, visit
https://gerrit.ovirt.org/64222
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7a13be40541fb268541bd8614a642263b96b487
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes