ShaoHe Feng has posted comments on this change.
Change subject: add verb for vdsm to tuneCpu params
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm_cli/vdsClient.py
Line 210: if len(args) > 1:
Line 211: for param in args[1:]:
Line 212: if '=' in param:
Line 213: key, value = param.split("=", 1)
Line 214: params[key] = value
what about no "=" in param?
can _eqSplit be here?
Line 215: return self.ExecAndExit(self.s.tuneCpu(params))
Line 216:
Line 217: def hotplugNic(self, args):
Line 218: nic = self._parseDriveSpec(args[1])
--
To view, visit
http://gerrit.ovirt.org/7492
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I09e02e09ef06ad6de45be75c3f2f913a3025750f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Zhu Bo <bozhu(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server