Dan Kenigsberg has posted comments on this change.
Change subject: storage: Search only the current image for children
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/35096/1/vdsm/storage/fileVolume.py
File vdsm/storage/fileVolume.py:
Line 360:
Line 361: def getChildren(self):
Line 362: """ Return children volume UUIDs.
Line 363:
Line 364: Children will always belong to the same image as this volume.
Is that true to template volumes, too?
Do we never instantiate a template volume, assuming to produce all dependent entities?
Line 365: """
Line 366: domPath = self.imagePath.split('images')[0]
Line 367: metaPattern = os.path.join(domPath, 'images', self.imgUUID,
'*.meta')
Line 368: metaPaths = oop.getProcessPool(self.sdUUID).glob.glob(metaPattern)
--
To view, visit
http://gerrit.ovirt.org/35096
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ef9012cee3a8cb891926510c10ecc47b7cddaa1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes